Device settings: Better visualize device operations [solved]

by gebhardm on Tue, 04/08/2015 - 12:26

As the discussion in https://www.flukso.net/content/new-firmware-and-upgrade-descriptions-dum... indicates, it may not be "obvious" on how to distinguish different device operations in the settings section of this website. For this purpose a simple mitigation is proposed, using the capabilities of the given CSS, to enhance the different operations' links by a <a href="/user/x/device/y/remove" class="btn btn-default" role="button">remove</a> instead of showing the operation just as text. This would provide a "more haptic" distinction resulting in the view as in attached screen capture.

Attachment	Size
flm_device_ops.PNG	10.63 KB

gebhardm | Tue, 04/08/2015 - 13:57

I assume the "root cause" of this "issue" is here: logger.admin.inc, line 196ff.

$row[] = l(t('remove'), $remove) . ' ' . l(t('upgrade'), $upgrade, array('attributes' => $attributes));

should be altered in

$button = array('class' => 'btn btn-default', 'role' => 'button');
$row[] = l(t('remove'), $remove, array('attributes' => $button)) . ' ' . l(t('upgrade'), $upgrade, array('attributes' => $attributes . $button));

but I am no Drupal expert...
Eventually just a comma in the ' ' of the first code line (#196) would solve the issue also ;-)

icarus75 | Thu, 27/08/2015 - 21:28

The UXD bug should be fixed with this commit. Thanks for the suggestion!